-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Copy Pull Command #21155
base: main
Are you sure you want to change the base?
Revamp Copy Pull Command #21155
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21155 +/- ##
==========================================
+ Coverage 45.36% 46.34% +0.97%
==========================================
Files 244 248 +4
Lines 13333 13925 +592
Branches 2719 2872 +153
==========================================
+ Hits 6049 6453 +404
- Misses 6983 7132 +149
- Partials 301 340 +39
Flags with carried forward coverage won't be shown. Click here to find out more. |
61337ab
to
5f4a463
Compare
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
* This commit moves "Copy Pull Command" button inside the table * and add a separate column for better usability Signed-off-by: bupd <[email protected]>
* This Commit adds Preferences in navbar * Updates the navbar Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
* Updates title of preference settings * Updates container runtime to pull cmd prefix Signed-off-by: bupd <[email protected]>
We can certainly discuss this from different angles, but at the end of the day, UX should always prioritize simplicity and clarity. 1 click > 3 clicks.Our focus should always be on what's best for the user. The UI should be intuitive, easy to understand, and foolproof, not a guessing game. For example, having a copy button above the datagrid, similar to Docker Hub, makes it much easier for users to copy exactly what they need, with clear feedback. This saves them unnecessary clicks and results in better UX overall. Thanks for considering this perspective! |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
docker pull project/repo
).These changes revamp the user experience, reducing clicks and improving the flow for copying pull commands.
Issue being fixed
Fixes #21146
Please indicate you've done the following: