-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update csrf key generation #21154
update csrf key generation #21154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21154 +/- ##
===========================================
+ Coverage 45.36% 66.09% +20.72%
===========================================
Files 244 1049 +805
Lines 13333 114654 +101321
Branches 2719 2867 +148
===========================================
+ Hits 6049 75775 +69726
- Misses 6983 34736 +27753
- Partials 301 4143 +3842
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We should make document this as a break change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes goharbor#21060 Do not generate a random key if the provided key has an invalid length. Signed-off-by: wang yan <[email protected]>
486aca9
to
f4962ba
Compare
Signed-off-by: wang yan <[email protected]>
Fixes #21060
Do not generate a random key if the provided key has an invalid length.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: