Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean #1329

Closed
wants to merge 26 commits into from
Closed

Add Korean #1329

wants to merge 26 commits into from

Conversation

jkh0kr
Copy link

@jkh0kr jkh0kr commented Nov 15, 2024

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@jkh0kr jkh0kr requested a review from a team as a code owner November 15, 2024 07:06
@deankarn
Copy link
Contributor

Thanks for the PR, the code isn't compiling though, I think because of an errand character here

translation: "{0}는 올바른 ISBN 번호여야 합니다".,

Korean translation. Error fixed
@jkh0kr
Copy link
Author

jkh0kr commented Nov 17, 2024

Korean translation. Error fixed

@jkh0kr
Copy link
Author

jkh0kr commented Nov 17, 2024

translation: "{0}는 올바른 ISBN 번호여야 합니다".,
to
translation: "{0}는 올바른 ISBN 번호여야 합니다.",

@jkh0kr
Copy link
Author

jkh0kr commented Nov 18, 2024

The ko_test.go file has also been modified in the same way.

@jkh0kr jkh0kr closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants