Thank you and some clarifications #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first of all, thanks for such a great and thorough explanation. Easily the most detailed explanation of deploying a create-react-app to Github I found and was the only way I was able to do it successfully. Thank you so much for providing this. Some suggestions that would have helped me: * on line 145: add a hard return because otherwise the `gh-page -b master -d build` gets spread over two lines. When I was going through this I didn't noticed it and only saw the `gh-page -b master -d` and tried to build it with that and it kept not working. Eventually got it working after re-reading the docs a number of times. * on line 173: added a paragraph and image to help people see where to find the project name. * on line 46: added a link to Github docs explaining the difference between a user site and a project site. I sat for a while confused as to which one I should use and the links provided both pointed to the same page, which also didn't have an explanation.
wrong screenshot
update w/ correct screenshot
* line 125: when I was going through the explanation I wasn't sure if I was supposed to add the "+" sign or not. I knew in commit histories that I had seen it before, but wasn't sure what the explanation here was wanting me to do. I ended up trying both before I figured out what the docs were trying to say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you so much for this. It was by far the most in-depth and thorough explanation of how to push a Create-React-App to my Github and the only documentation that actually explained it well. Thank-you, thank-you, thank-you.
I have added an explanation of things that I was actually confused with when I went through it, hoping these additions will clear up any confusion for the next person.
line 46: adds a link to explain what the difference between a user and a project file are.
line 125: The use of a "+" is not immediately clear that the "+" sign should not actually be added to the package.json file.
line 145: added a hard return. Without the hard return, the
gh-pages -b master -d buildline gets split into two lines. I read it asgh-pages -b master -dand didn't see thebuildsince it was on the next line and kept getting build error messages until I went back and re-read it several times.line 173 and 174: explanation of where to find the URL path for the project name and a screenshot to show them where.