Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @faker-js/faker to v9 #3774

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Upgrade @faker-js/faker to v9 #3774

merged 1 commit into from
Oct 23, 2024

Conversation

koesie10
Copy link
Member

This just upgrades Faker to v9 since this version was released more than a month ago and we haven't received a Dependabot update for it. The upgrade guide doesn't seem to contain anything that is relevant for us, so it's a simple bump of the dependency.

@koesie10 koesie10 marked this pull request as ready for review October 23, 2024 13:13
@koesie10 koesie10 requested a review from a team as a code owner October 23, 2024 13:13
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why dependabot didn't kick in?

@koesie10 koesie10 merged commit 791650f into main Oct 23, 2024
27 checks passed
@koesie10 koesie10 deleted the koesie10/upgrade-faker branch October 23, 2024 14:05
@koesie10
Copy link
Member Author

Any idea why dependabot didn't kick in?

Dependabot only opens 5 PRs by default, so it might not be able to keep up with the dependencies that are updated. We could increase the open-pull-requests-limit, but that will result in a lot more PRs being opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants