Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Github https repository getter utility #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alwell-kevin
Copy link
Contributor

Includes a javascript utility which enables a developer to GET a private GitHub Repository from an Organization over HTTPS (no GIT) using the CLI.

@azizshamim

@azizshamim azizshamim self-requested a review May 28, 2019 19:32
Copy link
Contributor

@jonico jonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor change suggestions inside

Comment on lines +25 to +30
const spiner = new Spinner('Retrieving your Project, please wait...');
spiner.start();

github.getRepo(gitHubMeta, spiner).then(function(repo) {
console.log("Got Project: ", gitHubMeta.repo)
spiner.stop();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const spiner = new Spinner('Retrieving your Project, please wait...');
spiner.start();
github.getRepo(gitHubMeta, spiner).then(function(repo) {
console.log("Got Project: ", gitHubMeta.repo)
spiner.stop();
const spinner = new Spinner('Retrieving your Project, please wait...');
spinner.start();
github.getRepo(gitHubMeta, spinner).then(function(repo) {
console.log("Got Project: ", gitHubMeta.repo)
spinner.stop();

var download = require("download");
var request = require('request');

var getRepo = (inputs, spiner) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var getRepo = (inputs, spiner) => {
var getRepo = (inputs, spinner) => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants