Merge pull request #237 from github/handle-unhandled-error

Update find_inactive_members.rb
github · Apr 3, 2019 · e9c2177 · e9c2177
2 parents f10f6db + 222478b
commit e9c2177
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/api/ruby/find-inactive-members/find_inactive_members.rb b/api/ruby/find-inactive-members/find_inactive_members.rb
@@ -127,6 +127,9 @@ def commit_activity(repo)
       end
     rescue Octokit::Conflict
       info "...no commits"
+    rescue Octokit::NotFound
+      #API responds with a 404 (instead of an empty set) when the `commits_since` range is out of bounds of commits.
+      info "...no commits"
     end
   end
 
@@ -263,4 +266,4 @@ def member_activity
 
 options[:client] = Octokit::Client.new
 
-InactiveMemberSearch.new(options)
+InactiveMemberSearch.new(options)