Use testcontainers to spawn MySQL server container in unit tests. #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurschreiber
requested review from
rashiq,
meiji163 and
timvaillancourt
as code owners
arthurschreiber
force-pushed
the
arthur/use-testcontainers
branch
from
07749f7
to
db9c69a
Compare
meiji163
approved these changes
Oct 21, 2024
2 tasks
arthurschreiber
added a commit
that referenced
this pull request
Oct 21, 2024
Use testcontainers to spawn MySQL server container in unit tests. #1457
mdelapenya
reviewed
Oct 30, 2024
|
|
||
| func (suite *ApplierTestSuite) SetupSuite() { | ||
| ctx := context.Background() | ||
| req := testcontainers.ContainerRequest{ |
There was a problem hiding this comment.
Hello from Testcontainers Go community! 👋 Thanks for using us
@arthurschreiber I'm here just to suggest using the dedicated MySQL module, if possible: https://golang.testcontainers.org/modules/mysql/
And please let us know if you need anything from our side 🙏
There was a problem hiding this comment.
👋 thanks for the suggestion! We will look into using this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests in
gh-ostare pretty basic right now. They often only verify simple behaviour like query generation, but fall short of testing more complex behaviours like actually running the changelog applier, because those require an actual MySQL instance to be running, and then might also depend on the exact settings of that instance, which we might not even have control over.By using
testcontainers-go, we can spawn MySQL containers using exactly the settings we want to test.This adds a few simple test cases to the
Appliertests that show how this could work.script/cibuildreturns with no formatting errors, build errors or unit test errors.