C++: Implement compilation_build_mode #18009
Conversation
cpp/ql/lib/semmlecode.cpp.dbscheme
Outdated
| * 1 = manual | ||
| * 2 = auto | ||
| */ | ||
| #keyset[id, mode] |
There was a problem hiding this comment.
You should be able to do something like the following (at the very least in a comment). That should give you some identifiers to refer to in the extractor instead of having to hardcoded constants.
case @compilation_build_mode.mode of
1 = @build_mode_none
| 2 = @build_mode_manual
| 3 = @build_mode_auto
;There was a problem hiding this comment.
Done. I did not realise this works in comments as well!
| description: Implement compilation_build_mode/2 | ||
| compatibility: backwards |
There was a problem hiding this comment.
This will need to delete the new table.
| @@ -78,7 +78,7 @@ | |||
| </e> | |||
| <e> | |||
| <k>@using_enum_declaration</k> | |||
| <v>1</v> | |||
| <v>0</v> | |||
There was a problem hiding this comment.
Looks like you didn't run the internal workflow we have to generate additional data from out tests.
There was a problem hiding this comment.
I ran the generate-db-stats workflow, downloaded the artefact, and merge was apparently successful:
[13:53:32] [DCA info] Normalizing stats by user-provided 'exprs'.
[13:53:32] [DCA info] Using stats from tests '~/Downloads/testsuite_stats.xml'.
[13:53:32] [DCA info] Using static stat files from /Users/calum/projects/codeql-dca/static-stats/cpp.
what am I missing?
There was a problem hiding this comment.
That's not possible for me to tell from this alone. Let's discuss internally?
calumgrant
force-pushed
the
calumgrant/bmn/record-build-mode
branch
from
0948649
to
4136f8d
Compare
cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/upgrade.properties
Outdated
Show resolved
Hide resolved
calumgrant
force-pushed
the
calumgrant/bmn/record-build-mode
branch
from
94f21f5
to
5bc9960
Compare
…e.properties Co-authored-by: Jeroen Ketema <[email protected]>
calumgrant
force-pushed
the
calumgrant/bmn/record-build-mode
branch
from
5bc9960
to
0836c3d
Compare
Pull Request checklist
All query authors
[ ] A change note is added if necessary. See the documentation in this repository.[ ] All new queries have appropriate.qhelp. See the documentation in this repository.[ ] New and changed queries have correct query metadata. See the documentation in this repository.Internal query authors only
[ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to.ql,.qll, or.qhelpfiles. See the documentation (internal access required).[ ] Adding a new query? Consider also adding the query to autofix.