Upgrade github/codeql dependency to 2.16.6
#742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Accept test changes from #15107
…dicates
We are planning to change the charpred of `Function` in the CodeQL C++ library,
which means the code changed here will no longer compile. By switching to the
extensionals, the code will keep compiling.
DIL before:
```
noinline
`ConstantExprs::isFunction/1#600714be`(
/* Element::Element */ interned unique entity el
)
{
exists(interned dontcare string _, interned dontcare int _1 |
functions(el, _, _1)
) or
exists(interned dontcare int _ | exprparents(el, _, el))
}
noopt
`ConstantExprs::callHasNoTarget/1#e6e8caa4`(
/* @funbindexpr */ interned unique entity fc
)
{
exists(/* Function::Function */ interned entity f |
funbind(fc, f) and not(`ConstantExprs::isFunction/1#600714be`(f))
)
}
```
DIL after:
```
noinline
`ConstantExprs::isFunction/1#600714be`(/* @element */ interned unique entity el)
{
exists(interned dontcare string _, interned dontcare int _1 |
functions(el, _, _1)
) or
exists(interned dontcare int _ | exprparents(el, _, el))
}
noopt
`ConstantExprs::callHasNoTarget/1#e6e8caa4`(
/* @funbindexpr */ interned unique entity fc
)
{
exists(/* @function */ interned entity f |
funbind(fc, f) and not(`ConstantExprs::isFunction/1#600714be`(f))
)
}
```
Use database extensionals instead of their wrapper classes in two predicates
Resolve name clash with CodeQL defined `UserDefinedLiteral`
The CodeQL test framework assumes that all code will become part to the same nameless link target, which means that the duplicate declarations of `test3` and `test4` are ODR violations. Moreover, newer versions of the C/C++ frontend used in the C/C++ extractor will implement CWG 2387, which means that the instantiations of `number_two` will also cause ODR violations. Fix the above by renaming `test3` and `test4` in `test`b.cpp` and making the `number_two` variable templates `static`.
Fix ODR violations in AUTOSAR A2-10-5 test
Accept changes from #15549
Accept more changes from #15549
Update test after frontend update
In the upgrade to 2.16.6 GuardCondition has been modified to use the IR instead of the AST mode it used before. One of the consequences of this change is that GuardConditions no longer exist for uninstantiated templates (because the IR does not apply for uninstantiated templates). Instead of using GuardCondition we can use the same logic for deducing infeasible paths for uninstantiated templates as for non template code. This avoids the dependency on GuardCondition, and provides consistency with the rest of the query, while shortening the query.
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
|
@knewbury01 I've requested you to review this upgrade, as I made some substantial changes to the The motivation was to eliminate the use of |
knewbury01
reviewed
Oct 22, 2024
|
@knewbury01 ready for re-review |
knewbury01
approved these changes
Oct 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the CodeQL CLI version to 2.16.6.
CodeQL dependency upgrade checklist:
github/codeqltest cases succeed.github/codeql-coding-standardsrepository.