go: add a page about YAML marshalling #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopiczko
commented
Sep 18, 2019
MarcelMue
approved these changes
Sep 18, 2019
rossf7
approved these changes
Sep 18, 2019
| > JSON methods MarshalJSON and UnmarshalJSON unlike go-yaml. | ||
|
|
||
| There is a good explanation for doing so written down here: | ||
| http://web.archive.org/web/20190603050330/http://ghodss.com/2014/the-right-way-to-handle-yaml-in-golang/. |
tomahawk28
approved these changes
Sep 18, 2019
| There is a good explanation for doing so written down here: | ||
| http://web.archive.org/web/20190603050330/http://ghodss.com/2014/the-right-way-to-handle-yaml-in-golang/. | ||
|
|
||
| This implies that we do not tag Go structs with `yaml` tags. Only `json` tags |
There was a problem hiding this comment.
I would highlight this phrase.
tuommaki
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in SIG operator.