Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): add fe check to allow managers and owners to always edit dashboards #81181

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

harshithadurai
Copy link
Member

add frontend check to allow managers and owners to always edit dashboards. this won't work until #80684 is merged

@harshithadurai harshithadurai requested a review from a team as a code owner November 22, 2024 16:19
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
8245 3 8242 0
View the top 3 failed tests by shortest run time
TransactionReplays should show a list of replays and have the correct values
Stack Traces | 0.135s run time
TestingLibraryElementError: Unable to find an element with the text: testDisplayName. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:109:15
    at Object.<anonymous> (.../transactionSummary/transactionReplays/index.spec.tsx:201:40)
Dashboards > Detail custom dashboards disables widget edit, duplicate, and delete button when user does not have edit perms
Stack Traces | 0.244s run time
Error: expect(element).toBeDisabled()

Received element is not disabled:
  <button aria-disabled="false" aria-label="Edit Dashboard" class="css-b13oqa-StyledButton-getColors e16hd6vm2" data-test-id="dashboard-edit" role="button" type="button" />
    at Object.<anonymous> (.../views/dashboards/detail.spec.tsx:1877:11)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)
Dashboards > Detail custom dashboards disables edit dashboard and add widget button if user cannot edit dashboard
Stack Traces | 0.294s run time
Error: expect(element).toBeDisabled()

Received element is not disabled:
  <button aria-disabled="false" aria-label="Edit Dashboard" class="css-b13oqa-StyledButton-getColors e16hd6vm2" data-test-id="dashboard-edit" role="button" type="button" />
    at Object.<anonymous> (.../views/dashboards/detail.spec.tsx:1812:11)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant