Fix pull CLI ops to avoid losing prefs for the GUI (#813)

Somehow, setting the sd in the pull CLI ops was losing prefs for the GUI, and users were asked to set it again in the next GUI launch. Also, setting the sd in CLI ops is not required (downstream code gets the briefcaseDir directly), so it's a safe change to do.
getodk · Sep 20, 2019 · f7cc413 · f7cc413
1 parent 4453351
commit f7cc413
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/src/org/opendatakit/briefcase/operations/PullFormFromAggregate.java b/src/org/opendatakit/briefcase/operations/PullFormFromAggregate.java
@@ -87,7 +87,6 @@ public static void pullFormFromAggregate(String storageDir, Optional<String> for
     FormCache formCache = FormCache.from(briefcaseDir);
     formCache.update();
     BriefcasePreferences appPreferences = BriefcasePreferences.appScoped();
-    appPreferences.setStorageDir(briefcaseDir);
     FormMetadataPort formMetadataPort = FileSystemFormMetadataAdapter.at(briefcaseDir);
 
     int maxHttpConnections = Optionals.race(

diff --git a/src/org/opendatakit/briefcase/operations/PullFormFromCentral.java b/src/org/opendatakit/briefcase/operations/PullFormFromCentral.java
@@ -70,7 +70,6 @@ private static void pullFromCentral(Args args) {
     FormCache formCache = FormCache.from(briefcaseDir);
     formCache.update();
     BriefcasePreferences appPreferences = BriefcasePreferences.appScoped();
-    appPreferences.setStorageDir(briefcaseDir);
     FormMetadataPort formMetadataPort = FileSystemFormMetadataAdapter.at(briefcaseDir);
 
     int maxHttpConnections = Optionals.race(