Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build Environment #75

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

jamesmcclain
Copy link
Member

@jamesmcclain jamesmcclain commented Jan 3, 2020

  • The Linux build now uses GDAL 2.4.3
  • The Macintosh build uses GDAL 2.4.2
  • The Windows build now uses GDAL 2.4.3

Connects #74

Todo:

  • Update README

@jamesmcclain
Copy link
Member Author

jamesmcclain commented Jan 3, 2020

@pomadchin

Edit: Sorry, I pasted the wrong output, before. I have corrected it.

This address the CI issue that you were experiencing on Linux, but does not address another one that apparently exists on Windows. Apparently CPLTurnFailureIntoWarning does not exists on Windows (I upgraded to the gisinternals.com GDAL 2.4.3 binary distribution and the function seems not to be there):

cc -Wall -Werror -Os -g com_azavea_gdal_GDALWarp.obj bindings.obj tokens.obj errorcodes.obj -L/windows/gdal/lib -lgdal_i -lstdc++ -lpthread -lws2_32 -shared -o gdalwarp_bindings.dll
bindings.obj: In function `locked_dataset::open()':
/workdir/src/locked_dataset.hpp:706: undefined reference to `CPLTurnFailureIntoWarning'
/workdir/src/locked_dataset.hpp:715: undefined reference to `CPLTurnFailureIntoWarning'
collect2: error: ld returned 1 exit status
Makefile:31: recipe for target 'gdalwarp_bindings.dll' failed
make: *** [gdalwarp_bindings.dll] Error 1
make: Leaving directory '/workdir/src'

That behavior should probably be behind a flag anyway, and should only exist on Linux and Macintosh.

@pomadchin
Copy link
Member

@jamesmcclain thanks for looking into it, this is very helpful

@jamesmcclain
Copy link
Member Author

@jamesmcclain thanks for looking into it, this is very helpful

No problem

@jamesmcclain jamesmcclain merged commit 9be712d into geotrellis:master Jan 13, 2020
@jamesmcclain jamesmcclain deleted the build-environment branch January 13, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants