Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trgt 1.2.0 #505

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Trgt 1.2.0 #505

wants to merge 14 commits into from

Conversation

Schmytzi
Copy link
Collaborator

@Schmytzi Schmytzi commented Nov 19, 2024

Closes #298. Removed local TRGT module and replaced it with trgt/genotype from nf-core.
Also replaced call to bcftools/merge with trgt/merge because bcftools drops most of the REF allele.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@Schmytzi Schmytzi marked this pull request as ready for review November 19, 2024 10:13
@Schmytzi Schmytzi requested a review from a team as a code owner November 19, 2024 10:13
Copy link
Collaborator

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! When I had a look previously, updating TRGT beyond 0.7.0 or something broke stranger. But perhaps this is not the case anymore?

conf/modules/call_repeat_expansions.config Show resolved Hide resolved
subworkflows/local/call_repeat_expansions/main.nf Outdated Show resolved Hide resolved
@jemten jemten mentioned this pull request Nov 22, 2024
10 tasks
@fellen31
Copy link
Collaborator

Also, if we add a tool for ONT-data, any ideas on how those calls should be merged if not with bcftools? I believe nf-core/raredisease uses SVDB merge.

@Schmytzi
Copy link
Collaborator Author

Nice! When I had a look previously, updating TRGT beyond 0.7.0 or something broke stranger. But perhaps this is not the case anymore?

As far as I can tell, it worked fine. I didn't check whether the annotations are the same, though.

@Schmytzi
Copy link
Collaborator Author

Also, if we add a tool for ONT-data, any ideas on how those calls should be merged if not with bcftools? I believe nf-core/raredisease uses SVDB merge.

I guess, if we process ONT data, we'd exclusively run the other tool, wouldn't we? Maybe there's a tool that works better with whatever becomes our ONT tool

@fellen31
Copy link
Collaborator

fellen31 commented Nov 28, 2024

I guess, if we process ONT data, we'd exclusively run the other tool, wouldn't we? Maybe there's a tool that works better with whatever becomes our ONT tool

What I meant was that it would be nice if we could still merge using the same tool, regardless of the caller. But we can take that when we get there.

Copy link
Collaborator

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I tested your branch and it seems to work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Update TRGT to 1.2.0
2 participants