-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trgt 1.2.0 #505
base: dev
Are you sure you want to change the base?
Trgt 1.2.0 #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! When I had a look previously, updating TRGT beyond 0.7.0 or something broke stranger. But perhaps this is not the case anymore?
subworkflows/local/call_repeat_expansions/tests/main.nf.test.snap
Outdated
Show resolved
Hide resolved
Also, if we add a tool for ONT-data, any ideas on how those calls should be merged if not with bcftools? I believe nf-core/raredisease uses SVDB merge. |
As far as I can tell, it worked fine. I didn't check whether the annotations are the same, though. |
I guess, if we process ONT data, we'd exclusively run the other tool, wouldn't we? Maybe there's a tool that works better with whatever becomes our ONT tool |
What I meant was that it would be nice if we could still merge using the same tool, regardless of the caller. But we can take that when we get there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I tested your branch and it seems to work well.
Closes #298. Removed local TRGT module and replaced it with trgt/genotype from nf-core.
Also replaced call to bcftools/merge with trgt/merge because bcftools drops most of the REF allele.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).