Set BUNDLE_BIN_PATH during exec #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our command is obviously less featureful than 'bundle', but if you're running inside a Gel context, I think you still have a better chance of success from 'gel' than from 'bundle'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PoLS trade-off: our command is obviously less featureful than 'bundle', but if you're running inside a Gel context, I think you still have a better chance of success from 'gel' than from 'bundle'.
I've generally tried to avoid touching explicitly bundle-y env vars, but this seems like a fair exception, and should be particularly useful for applications that wish to work with both systems: switching from
system("bundle")tosystem(ENV.fetch("BUNDLE_BIN_PATH", "bundle"))is a small upgrade even in a Bundler context, while also adding Gel support without forcing widespread "if gel else bundler" conditions.Fixes #124