Don't count first when we're doing a real query. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the appstats tool for my GAE project, I found that counting the entities in a query before executing it took about 160% as long as just executing the query (with no count). Unless it is expected that most queries will return zero results, counting first doesn't make sense.
|
Nice catch. Your patch looks pretty good, I'll merge it in for the next version of appengine-magic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the appstats tool for my GAE project, I found that counting the entities in a query before executing it took about 160% as long as just executing the query (with no count). Unless it is expected that most queries will return zero results, counting first doesn't make sense.