deterministic hugepage size, set without kexec #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
fwiesel
requested changes
Nov 25, 2024
| @@ -0,0 +1 @@ | |||
| CMDLINE_LINUX="$CMDLINE_LINUX default_hugepagesz=1G" | |||
There was a problem hiding this comment.
We do not want to change the hugepagesz, the default (2MB) is fine.
Comment on lines
+44
to
+54
| #cmdline="$(</proc/cmdline) hugepages=$hugepages" | ||
| #release=$(uname -r) | ||
|
|
||
| #NEWROOT=${NEWROOT:-/sysroot} | ||
|
|
||
| #kexec \ | ||
| # -l $NEWROOT/boot/vmlinuz-${release} \ | ||
| # --initrd=$NEWROOT/boot/initrd.img-${release} \ | ||
| # --command-line="$cmdline" | ||
|
|
||
| #kexec -e --reset-vga |
There was a problem hiding this comment.
Could you please remove it instead?
| @@ -12,5 +12,5 @@ depends() { | |||
| # Install the required file(s) and directories for the module in the initramfs. | |||
| install() { | |||
| inst_hook pre-pivot 00 "$moddir/ensure-hugepages.sh" | |||
| inst kexec | |||
| #inst kexec | |||
There was a problem hiding this comment.
Please remove that comment as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hugepaes have not been set deterministically, fixed by adding it to the kernel cmdline
added a direct application of hugepages to dracut -> no kexec needed anymore
has a slight delay but in initrd this still should be fast.