Fixes ConcurrentModificationException mentioned in Issue #47 #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crash was our app's most common crash prior to making this change.
After this change, we've had zero ConcurrentModificationExceptions and our crash-free sessions are up to over 99%.
Hashset is not thread-safe and the use of the
synchronized
keyword was still allowing the crash to happen in the iterator'snext()
method.We are using this fork in our production app with no issues.