Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agent):Add okapibm25 agent #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(agent):Add okapibm25 agent #101

wants to merge 1 commit into from

Conversation

its-sushant
Copy link
Contributor

Description

Add a agent for bm25Okapi agent.

Files

  • agents/bm25.py

How to use

  • Running bm25 agent
    atarashi -a bm25 /path/to/file.c

  • Checking accuracy using evaluator.py
    python3 path/to/evaluator.py -a bm25

Accuracy

The accuracy score that has been tested using evaluator.py is 62%

CC: @Kaushl2208 @GMishx @hastagAB @ag4ums @vasudevmaduri

@GMishx
Copy link
Member

GMishx commented Jul 17, 2022

Thank you for your contribution @its-sushant but the library rank-bm25 is Apache-2.0 licensed which is not compatible with GPL-2.0 license of Atarashi.

Please find an alternate of the library which is not GPL-3.0, Apache-* and AGPL-*.

@GMishx GMishx added enhancement New feature or request wontfix This will not be worked on GSoC-22 Label to tag issues and pull request for GSoC 2022 activities bug Something isn't working and removed wontfix This will not be worked on labels Jul 17, 2022
@hastagAB
Copy link
Member

Thank you for your contribution @its-sushant but the library rank-bm25 is Apache-2.0 licensed which is not compatible with GPL-2.0 license of Atarashi.

Please find an alternate of the library which is not GPL-3.0, Apache-* and AGPL-*.

@GMishx @its-sushant Can we implement BM25 algo in-house for Atarashi?

@its-sushant
Copy link
Contributor Author

Thank you for your contribution @its-sushant but the library rank-bm25 is Apache-2.0 licensed which is not compatible with GPL-2.0 license of Atarashi.
Please find an alternate of the library which is not GPL-3.0, Apache-* and AGPL-*.

@GMishx @its-sushant Can we implement BM25 algo in-house for Atarashi?

Sure, we can implement bm25 transformer itself in Atarashi. I have already started working on it and will revert the changes as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request GSoC-22 Label to tag issues and pull request for GSoC 2022 activities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@its-sushant @GMishx @hastagAB