Test that element.requestFullscreen() consumes user activation

This makes a bunch of other tests redundant, as they're also calling requestFullscreen() twice, and should all fail in exactly the same way. element-request-fullscreen-same-manual.html is also converted to ensure that a second call in a new click does work, to ensure the failure isn't because the element is the same as the fullscreen element. Follows whatwg/fullscreen#153.
foolip · Nov 15, 2022 · 86d83d5 · 86d83d5
1 parent f119ebc
commit 86d83d5
Show file tree

Hide file tree

Showing 9 changed files with 53 additions and 309 deletions.
diff --git a/fullscreen/api/element-request-fullscreen-consume-user-activation.html b/fullscreen/api/element-request-fullscreen-consume-user-activation.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<title>Element#requestFullscreen() consumes user activation</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+<div id="log"></div>
+<script>
+promise_test(async (t) => {
+    t.add_cleanup(() => { document.exitFullscreen() });
+
+    const div = document.querySelector("div");
+
+    const promises = [];
+
+    await test_driver.bless("fullscreen", () => {
+      // Request fullscreen twice in a row. The first request should consume the
+      // user activation and succeed, and the second request should fail because
+      // of the user activation requirement.
+      const p1 = div.requestFullscreen();
+      const p2 = div.requestFullscreen();
+      promises.push(p1);
+      promises.push(promise_rejects_js(t, TypeError, p2));
+    });
+
+    await Promise.all(promises);
+});
+</script>
diff --git a/fullscreen/api/element-request-fullscreen-same-element.html b/fullscreen/api/element-request-fullscreen-same-element.html
@@ -0,0 +1,25 @@
+<!DOCTYPE html>
+<title>Element#requestFullscreen() on the current fullscreen element</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+<div id="log"></div>
+<script>
+promise_test(async (t) => {
+    t.add_cleanup(() => { document.exitFullscreen() });
+
+    // Use the body element as the fullscreen element, because the second
+    // test_driver.bless() call needs to insert a button inside of it, which
+    // can't be clicked if another element is already fullscreen.
+    const target = document.body;
+
+    // First enter fullscreen.
+    await test_driver.bless("fullscreen", () => target.requestFullscreen());
+    assert_equals(document.fullscreenElement, target, "fullscreen element after first request");
+
+    // Now request fullscreen again, which should be a no-op.
+    await test_driver.bless("fullscreen", () => target.requestFullscreen());
+    assert_equals(document.fullscreenElement, target, "fullscreen element after second request");
+});
+</script>
diff --git a/fullscreen/api/element-request-fullscreen-same-manual.html b/fullscreen/api/element-request-fullscreen-same-manual.html
diff --git a/fullscreen/api/element-request-fullscreen-twice-manual.html b/fullscreen/api/element-request-fullscreen-twice-manual.html
diff --git a/fullscreen/api/element-request-fullscreen-twice-manual.tentative.html b/fullscreen/api/element-request-fullscreen-twice-manual.tentative.html
diff --git a/fullscreen/api/element-request-fullscreen-two-elements-manual.html b/fullscreen/api/element-request-fullscreen-two-elements-manual.html
diff --git a/fullscreen/api/element-request-fullscreen-two-elements-manual.tentative.html b/fullscreen/api/element-request-fullscreen-two-elements-manual.tentative.html
diff --git a/fullscreen/api/element-request-fullscreen-two-iframes-manual.html b/fullscreen/api/element-request-fullscreen-two-iframes-manual.html
diff --git a/fullscreen/api/element-request-fullscreen-two-iframes-manual.tentative.html b/fullscreen/api/element-request-fullscreen-two-iframes-manual.tentative.html