UIU-3290: Fix issue with Proxy borrower field value
#2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dmytro-Melnyshyn
approved these changes
Dec 3, 2024
UladzislauKutarkin
approved these changes
Dec 3, 2024
zburke
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
The subtle bugs in the lifecycle methods of these old class-based components are so sneaky. Thank you for the clean up effort here!
In the PR description, please describe the state of the code after the bug has been fixed, e.g. "Consistently display Proxy borrower field". You don't need to describe the bug (the bug is gone, and we care about what the code looks like now, not what it used to look like).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proxy borrowerfield has incorrect value from time to time. In some cases it shows correct name, in other cases it shows "Unknown user" for the same loan.Approach
Display correct Proxy borrower name for loan. In a case if user is not found display "Unknown user".
Refs
UIU-3290