in_kafka: document enable_auto_commit #1520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CoreidCC <[email protected]>
lockewritesdocs
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Thanks @coreidcc! I suggested some minor changes to align with style.
| @@ -16,6 +16,8 @@ This plugin uses the official [librdkafka C library](https://github.com/edenhill | |||
| | Buffer\_Max\_Size | Specify the maximum size of buffer per cycle to poll kafka messages from subscribed topics. To increase throughput, specify larger size. | 4M | | |||
| | rdkafka.{property} | `{property}` can be any [librdkafka properties](https://github.com/edenhill/librdkafka/blob/master/CONFIGURATION.md) | | | |||
| | threaded | Indicates whether to run this input in its own [thread](../../administration/multithreading.md#inputs). | `false` | | |||
| | enable_auto_commit | Use kafa auto-commit instead of commiting easch individual message. | `false` | | |||
There was a problem hiding this comment.
Suggested change
| | enable_auto_commit | Use kafa auto-commit instead of commiting easch individual message. | `false` | | |
| | enable_auto_commit | Use Kafka auto-commit instead of committing each individual message. | `false` | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation related to the pull-request 'Boost in_kafa throughput #9625' submitted to fluent-bit.