[fix] connect() filter caused a crash as used with a onState callback

flomesh-io · Jun 21, 2024 · d36b333 · d36b333
1 parent e2cb55c
commit d36b333
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/filters/connect.cpp b/src/filters/connect.cpp
@@ -209,6 +209,7 @@ void Connect::process(Event *evt) {
     }
 
     try {
+      m_outbound->open();
       if (bind) {
         m_outbound->bind(bind->str());
       } else if (options.protocol == Outbound::Protocol::NETLINK) {

diff --git a/src/outbound.cpp b/src/outbound.cpp
@@ -112,6 +112,10 @@ auto Outbound::address() -> pjs::Str* {
   return m_address;
 }
 
+void Outbound::open() {
+  state(Outbound::State::open);
+}
+
 void Outbound::close(StreamEnd *eos) {
   InputContext ic;
   retain();
@@ -260,7 +264,6 @@ OutboundTCP::OutboundTCP(EventTarget::Input *output, const Outbound::Options &op
   , SocketTCP(false, Outbound::m_options)
   , m_resolver(Net::context())
 {
-  state(Outbound::State::open);
 }
 
 OutboundTCP::~OutboundTCP() {
@@ -514,7 +517,6 @@ OutboundUDP::OutboundUDP(EventTarget::Input *output, const Outbound::Options &op
   , SocketUDP(false, Outbound::m_options)
   , m_resolver(Net::context())
 {
-  state(Outbound::State::open);
 }
 
 OutboundUDP::~OutboundUDP() {

diff --git a/src/outbound.hpp b/src/outbound.hpp
@@ -114,6 +114,7 @@ class Outbound :
   virtual auto get_traffic_in() ->size_t = 0;
   virtual auto get_traffic_out() ->size_t = 0;
 
+  void open();
   void close(StreamEnd *eos);
 
 protected: