[fix] Stdout/stderr shouldn't have been closed when Logger::StdoutTar…

…get is deleted

src/api/logging.cpp

@@ -236,6 +236,12 @@ void Logger::History::dump_messages(Data &buffer) {
 // Logger::StdoutTarget
 //
 
+Logger::StdoutTarget::~StdoutTarget() {
+  if (m_file_stream) {
+    m_file_stream->close(false);
+  }
+}
+
 void Logger::StdoutTarget::write(const Data &msg) {
   if (Net::current().is_running()) {
     if (!m_file_stream) m_file_stream = FileStream::make(false, m_f, &s_dp_stdout);

src/api/logging.hpp

@@ -83,6 +83,7 @@ class Logger : public pjs::ObjectTemplate<Logger> {
   class StdoutTarget : public Target {
   public:
     StdoutTarget(FILE *f) : m_f(f) {}
+    ~StdoutTarget();
 
   private:
     virtual void write(const Data &msg) override;

src/fstream.cpp

@@ -49,9 +49,13 @@ FileStream::FileStream(bool read, FILE *f, Data::Producer *dp)
   if (read) this->read();
 }
 
-void FileStream::close() {
+void FileStream::close(bool close_fd) {
   std::error_code ec;
-  m_stream.close(ec);
+  if (close_fd) {
+    m_stream.close(ec);
+  } else {
+    m_stream.release();
+  }
 
   if (m_receiving_state == PAUSED) {
     m_receiving_state = RECEIVING;
@@ -65,7 +69,7 @@ void FileStream::close() {
   }
 
   if (m_f) {
-    fclose(m_f);
+    if (close_fd) fclose(m_f);
     m_f = nullptr;
   }
 }

src/fstream.hpp

@@ -58,7 +58,7 @@ class FileStream :
 
   auto fd() const -> int { return m_fd; }
   void set_buffer_limit(size_t size) { m_buffer_limit = size; }
-  void close();
+  void close(bool close_fd = true);
 
 private:
   FileStream(bool read, int fd, Data::Producer *dp);