-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deps): Update metrics to 0.23. Note: 0.22 was a major change… #189
Open
jeckhart
wants to merge
1
commit into
fission-codes:main
Choose a base branch
from
jeckhart:je-upgrade-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and required some refactor of the metrics
@jeckhart thanks for taking this on, was on my agenda for too long. |
@jeckhart mind showing just an output of the metrics in action? |
Metrics output:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and required some refactor of the metrics
Description
Upgrade to the latest metrics library. There was a relatively significant breaking changes to metrics introduced in metrics 0.22 so this also addresses several of the metrics changes.
Type of change
Please delete options that are not relevant.
Test plan (required)
Run all unit and CI tests and get to green.
Additionally, install prometheus and view that the metrics returned are actually working and valid.
Screenshots/Screencaps
Please include a screenshot or screencap that includes any commands that have been added to the generator.