Add support for the get_vcpu_ms hostcall #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeshaw
reviewed
Aug 16, 2024
fgsch
reviewed
Aug 17, 2024
fgsch
reviewed
Aug 17, 2024
cee-dub
requested changes
Aug 18, 2024
|
The test failures here make me wonder if we need to bump our Viceroy requirement? |
Co-authored-by: Federico G. Schwindt <[email protected]>
|
The timout during the test makes me think it might be a scheduler issue where the process isn't running asynchronously because something is stalled in the sleep. I can look into this more. |
cee-dub
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a hostcall that fetches the amount of time that the guest has spent on the VCPU, but does not include any time the guest has spent idle. The Viceroy implementation is forthcoming.
The raw hostcall provides this value in milliseconds, but the little reading on time in Go suggested that translating this to a
Durationwould be more natural. I can revisit this decision, or obviously folks can reach in and get the raw millisecond value from the internal library.The test case included makes sure that we don't count sleeping time. It may be worth adding an additional test to verify that we do count active time.