🗣️ Pass verbosity flag along to viceroy binary #878
Conversation
| @@ -591,6 +591,7 @@ func local(bin, file, addr, env string, debug, watch bool, watchDir cmd.Optional | |||
| text.Break(out) | |||
| text.Output(out, "Wasm file: %s", file) | |||
| text.Output(out, "Manifest: %s", manifestPath) | |||
| args = append(args, "-v") | |||
There was a problem hiding this comment.
👋 Thanks for opening this PR to address this issue.
CLI users very rarely use --verbose mode because of the extra noise, so I think the default behaviour should be to pass the -v flag regardless of whether the verbose mode was set in the CLI (we've already had a few users confused by the missing output because they no longer see the local server address so they don't know where to go).
An alternative would be to keep this change -v (as it might address other issues raised specifically for Viceroy, see this PR's description) and instead have the CLI additionally print the address unless the user sets CLI to use verbose mode. This is because on line 71 we set a default address .Default("127.0.0.1:7676") so the CLI does know the address up front but we'd want to avoid the duplication of information if viceroy also is in verbose mode.
There was a problem hiding this comment.
Actually, thinking about this a little more I'm going to go with the 'alternative' option as I think that makes the most sense. So I'll approve/merge this PR and open a separate PR to address the other aspects of the alternative approach.
Putting this up as a possible solution to fastly/Viceroy#235.
With the 0.4.0 release, the default Viceroy verbosity is "OFF" rather than "INFO" (discussion here). This change would pass along the
--verboseflag to viceroy when a user callsfastly compute serve --verbose.Alternatively, we could just unconditionally pass the
-vflag so thefastly compute serveoutput remains ~the same as before that Viceroy version.