Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable custom profiling interval via CLI flag (#357) #437

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Enable custom profiling interval via CLI flag (#357) #437

wants to merge 9 commits into from

Commits on Oct 12, 2024

  1. Add guest profile interval

    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    158116b View commit details
    Browse the repository at this point in the history

  2. Update the profiler mode checking function 

    Add match case for when interval is None, and when one exists
    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    882a9ff View commit details
    Browse the repository at this point in the history

  3. Add profile_guest_interval() to RunArgs aswell 

    also update `profile_guest()`, ignore interval in that function
    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    8b65baa View commit details
    Browse the repository at this point in the history

  4. Add profile interval in ExecuteCtx

    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    f2e07d0 View commit details
    Browse the repository at this point in the history

  5. Pass profiler interval when starting Viceroy

    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    927c59c View commit details
    Browse the repository at this point in the history

  6. Update documentation to specify milliseconds

    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    13f2cd2 View commit details
    Browse the repository at this point in the history

  7. Update ExecuteCtx arguments in tests 

    Pass `None` for profiling interval in tests
    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    1a88bd0 View commit details
    Browse the repository at this point in the history

  8. Update example code in comments 

    ExecuteCtx::new takes an additional argument now, namely the profiling interval.
    @omarjatoi
    omarjatoi committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    86f7c58 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Support humantime compatible profile interval 

    - Should be allowed to pass interval as `100ms` or `100` and default to milliseconds
    @omarjatoi
    omarjatoi committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6042fe9 View commit details
    Browse the repository at this point in the history