Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the alignment check in the adapter's allocator #434

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix the alignment check in the adapter's allocator #434

merged 1 commit into from
Oct 4, 2024

Conversation

elliottt
Copy link
Contributor

@elliottt elliottt commented Oct 4, 2024

Integrate bytecodealliance/wasmtime#9356 into the adapter, to fix allocations of zero-bytes from a zero-byte buffer.

@elliottt elliottt requested a review from acw October 4, 2024 15:48
acw
acw approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@acw acw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate > vs >=

@elliottt elliottt merged commit 9337575 into main Oct 4, 2024
15 checks passed
@elliottt elliottt deleted the trevor/fix-adaptor-cabi-realloc-alignment branch October 4, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acw acw acw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliottt @acw