Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReplaceHandle hostcall stubs for upcoming SDK release #424

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ulyssa
Copy link
Contributor

@ulyssa ulyssa commented Sep 3, 2024

The upcoming Rust SDK release will include an API for using replace_* variants of a number of the existing cache API hostcalls that operate on a ReplaceHandle. Since Viceroy doesn't handle any of the caching APIs for now, this PR only adds stubs for these hostcalls and returns an error just like the existing ones do.

@ulyssa ulyssa requested review from acw and elliottt September 3, 2024 20:08
Copy link
Contributor

@acw acw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ulyssa ulyssa merged commit a1b225d into main Sep 3, 2024
15 checks passed
@ulyssa ulyssa deleted the ulyssa/cache-replace-stubs branch September 3, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants