Rename the kv-store interface to object-store in compute.wit #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/object-store-interface
branch
3 times, most recently
from
68cc150
to
86c11f4
Compare
elliottt
force-pushed
the
trevor/object-store-interface
branch
3 times, most recently
from
cd31461
to
ab2388a
Compare
elliottt
changed the title
elliottt
force-pushed
the
trevor/object-store-interface
branch
from
ab2388a
to
7b98992
Compare
acw
approved these changes
Aug 21, 2024
| /* | ||
| * Fastly KV Store | ||
| */ | ||
| interface kv-store { |
There was a problem hiding this comment.
Is there any sort of deprecation tag (or even a comment) we can put here?
There was a problem hiding this comment.
There is, but we could instead just remove the object-store interface and polyfill it in the adapter with the new kv-store import. Either way, let's hold off until the kv-store interface has been filled out :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
kv-storeinterface in compute.wit toobject-store, and addtodo!()implementations for the newkv-storeinterface. The host implementations of those functions will be added in a follow-up PR along with the wiggle implementation for the new host calls, however the adapter has been updated to handle the new hostcalls already.I tried to structure the commits so that it shows the renaming and updates to
object_store.rsas an actual diff, but github is not cooperating. Looking at the individual commits should show that the changes toobject_store.rsincludes a renaming and small changes to the original implementation, whilekv_store.rsis a completely fresh implementation of a new interface.cc @computermouth