-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 Prepare release v0.10.0 #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this needs to be a major version bump to 0.10.0, as the viceroy-lib
public interface includes types from wasmtime
which got a major bump. There are also a couple of public definitions within the crate itself whose types have changed.
Given the large surface area of exports from the viceroy-lib
crate, we might want to consider a policy similar to Wasmtime of just making a major bump on every release in order to avoid accidental semver breaks. Or making many more things private to limit the surface area we have to audit when deciding on the next release's version.
That makes sense! I've bumped the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to release per step 6 of the release process 🚀
Yeah, the tag name is what counts |
EDIT: It actually just needed a |
The `viceroy-component-adapter` does not need to be built in the release builds, since it is meant to be rebuilt with `make adapter` and then have the generated WASM binary under `lib/data/` committed.
Hmm, glad you found a workaround, but flagging this for @elliottt when he's back. There's definitely some awkwardness about having the adapter where it currently sits. |
02a15e6 adds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thank you for navigating this unusual release!
This updates the lockfiles with
make generate-lockfile
as mentioned in RELEASING.md, and updates theCHANGELOG.md
to include the commits added since #375.Rendered view of the changelog is here.