Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Prepare release v0.10.0 #404

Merged
merged 3 commits into from
Jul 9, 2024
Merged

🎁 Prepare release v0.10.0 #404

merged 3 commits into from
Jul 9, 2024

Conversation

ulyssa
Copy link
Contributor

@ulyssa ulyssa commented Jul 8, 2024

This updates the lockfiles with make generate-lockfile as mentioned in RELEASING.md, and updates the CHANGELOG.md to include the commits added since #375.

Rendered view of the changelog is here.

@ulyssa ulyssa marked this pull request as ready for review July 8, 2024 20:10
@ulyssa ulyssa requested review from acw, acfoltzer and aturon July 8, 2024 20:10
Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this needs to be a major version bump to 0.10.0, as the viceroy-lib public interface includes types from wasmtime which got a major bump. There are also a couple of public definitions within the crate itself whose types have changed.

Given the large surface area of exports from the viceroy-lib crate, we might want to consider a policy similar to Wasmtime of just making a major bump on every release in order to avoid accidental semver breaks. Or making many more things private to limit the surface area we have to audit when deciding on the next release's version.

@ulyssa ulyssa changed the title 🎁 Prepare release v0.9.8 🎁 Prepare release v0.10.0 Jul 9, 2024
@ulyssa ulyssa requested a review from acfoltzer July 9, 2024 19:28
@ulyssa
Copy link
Contributor Author

ulyssa commented Jul 9, 2024

That makes sense! I've bumped the Cargo.toml files to use 0.10.0, and updated the CHANGELOG.md to reflect the new version number. (I can't change the source branch of the PR, but I can close and open a new one if the branch name is important; it looks like previous PRs automatically deleted the branch, so only the tag will matter, I think.)

acfoltzer
acfoltzer previously approved these changes Jul 9, 2024
Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to release per step 6 of the release process 🚀

@acfoltzer
Copy link
Contributor

(I can't change the source branch of the PR, but I can close and open a new one if the branch name is important; it looks like previous PRs automatically deleted the branch, so only the tag will matter, I think.)

Yeah, the tag name is what counts

@ulyssa
Copy link
Contributor Author

ulyssa commented Jul 9, 2024

It looks like the release.yml may need the same test.yml changes made in #398 in order to build the component adapter.

EDIT: It actually just needed a --exclude viceroy-component-adapter since the WASM artifact is already built and checked into the repo. I've rebuilt it since I didn't do that in #402. (I'm not sure if there's a good way to check for missing updates to it in test.yml, since I imagine the output changes depending on which version of Rust is used to build it locally.)

The `viceroy-component-adapter` does not need to be built in the release
builds, since it is meant to be rebuilt with `make adapter` and then
have the generated WASM binary under `lib/data/` committed.
@acfoltzer
Copy link
Contributor

Hmm, glad you found a workaround, but flagging this for @elliottt when he's back. There's definitely some awkwardness about having the adapter where it currently sits.

@ulyssa
Copy link
Contributor Author

ulyssa commented Jul 9, 2024

02a15e6 adds ## Unreleased back to the top of CHANGELOG.md and updates the version to v0.10.1 for now. If we want to make each release a breaking change going forward, we can update it to 0.11.0 on the next release.

Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thank you for navigating this unusual release!

@ulyssa ulyssa merged commit a63db3a into main Jul 9, 2024
7 checks passed
@ulyssa ulyssa deleted the release-0.9.8 branch July 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants