🔨 Populate the guest cli args #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameysharp
previously approved these changes
Jun 26, 2024
| let mut store = create_store(&self, session, profiler, |_| {}) | ||
| .map_err(ExecutionError::Context)?; | ||
| let mut store = create_store(&self, session, profiler, |ctx| { | ||
| ctx.arg("compute-app"); |
There was a problem hiding this comment.
Do you also want to add this for the ComponentCtx::create_store case as well?
There was a problem hiding this comment.
I've added this for components and enabled testing for it, but the adapter will need some changes to get the test passing. I'll put that on my TODO list for component parity, but don't think the adapter changes should block this PR.
elliottt
force-pushed
the
trevor/guest-args
branch
2 times, most recently
from
33c87ad
to
7a8e4f3
Compare
elliottt
force-pushed
the
trevor/guest-args
branch
from
7a8e4f3
to
b39997b
Compare
jameysharp
approved these changes
Jun 26, 2024
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
Populate the guest cli args with the single value "compute-app". This should simplify adoption for languages that assume the args list is non-empty. Fixes fastly#376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate the guest cli args with the single value
"compute-app". This should simplify adoption for languages that assume the args list is non-empty.Fixes #376