Switch to reading dictionaries during the fastly_dictionary_open call
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/read-dictionary-during-open
branch
from
ba68e2b
to
1942418
Compare
Read dictionaries during the `open` host call instead of once for each `get` call. This improves viceroy performance for large dictionaries, and more closely matches the semantics of the production environment, as changes made while the dictionary is open won't be reflected in subsequent `get` calls. Additionally, remove the `DictionaryName` newtype, as it wasn't offering anything over using a `String` directly. co-authored-by: Jamey Sharp <[email protected]>
elliottt
force-pushed
the
trevor/read-dictionary-during-open
branch
from
1942418
to
e65851a
Compare
acfoltzer
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Great improvement on the reduced parsing!
I have mixed feelings about removing DictionaryName; I suspect it was set up as a newtype in order to potentially encode the platform restrictions on dictionary names. But if it's not being used for that right now, we might as well get rid of it... there's already some deferred work hiding here to differentiate between dictionaries and config stores, and enforcing name restrictions would probably be better done at that point.
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
…ll (fastly#379) Read dictionaries during the `open` host call instead of once for each `get` call. This improves viceroy performance for large dictionaries, and more closely matches the semantics of the production environment, as changes made while the dictionary is open won't be reflected in subsequent `get` calls. Additionally, remove the `DictionaryName` newtype, as it wasn't offering anything over using a `String` directly. Co-authored-by: Jamey Sharp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read dictionaries during the
openhost call instead of once for eachgetcall. This improves viceroy performance for large dictionaries, and more closely matches the semantics of the production environment, as changes made while the dictionary is open won't be reflected in subsequentgetcalls.Additionally, remove the
DictionaryNamenewtype, as it wasn't offering anything over using aStringdirectly.co-authored-by: Jamey Sharp [email protected]