Return HttpInvalid error instead of FastlyStatus::Error when failed to build Uri #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastly Rust SDK maps
FastlyStatus::Error
toBackendCreationError::NameInUse
.By this, when we passed invalid host name value to
fastly::Backend::builder
func, we always receivedNameInUse
error.It's a misleading behavior for developers, who will assume they register the same backend multiple times.
In this PR, I defined a new internal Error
InvalidBackendUrl
and map it asFastlyStatus::HttpInvalid
.It will help developers to awake they are using invalid URI to build the dynamic backend.
Example
before
after