Support adapting core wasm to components #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/component-adapter
branch
2 times, most recently
from
ee9e367
to
c6ef717
Compare
elliottt
force-pushed
the
trevor/component-adapter
branch
3 times, most recently
from
698ec38
to
79e86af
Compare
elliottt
force-pushed
the
trevor/component-adapter
branch
from
fa14e8e
to
f01603a
Compare
elliottt
force-pushed
the
trevor/component-adapter
branch
from
f01603a
to
ca403cf
Compare
elliottt
changed the title
adapt command to produce components from core wasm
acfoltzer
suggested changes
Jun 5, 2024
elliottt
force-pushed
the
trevor/component-adapter
branch
from
2bbaa2d
to
7a29848
Compare
acfoltzer
approved these changes
Jun 5, 2024
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
This PR adds a component adapter based on the wasi_snapshot_preview1 adapter that also supports the fastly host call abi. The adapter can be used in two forms: 1. using the new viceroy adapt command to adapt a core-wasm module to a component ahead-of-time, 2. using the --adapt flag to viceroy serve or viceroy run, adapting the core-wasm in-memory. This functionality opens the door to running viceroy's existing test suite with components, and also to a longer-term migration towards components in-general. This feature comes with a downside to the development experience though: any changes made to the adapter require that we also run the make adapter target, and commit the changes to the wasi_snapshot_preview1.wasm binary. It would be great to check if this was necessary in CI, but it's not clear to me what the right mechanism is to enforce that. However, changes to the adapter should be infrequent, so hopefully this isn't too much of a burden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a component adapter based on the wasi_snapshot_preview1 adapter that also supports the fastly host call abi. The adapter can be used in two forms:
viceroy adaptcommand to adapt a core-wasm module to a component ahead-of-time,--adaptflag toviceroy serveorviceroy run, adapting the core-wasm in-memory.This functionality opens the door to running viceroy's existing test suite with components, and also to a longer-term migration towards components in-general.
This feature comes with a downside to the development experience though: any changes made to the adapter require that we also run the
make adaptertarget, and commit the changes to thewasi_snapshot_preview1.wasmbinary. It would be great to check if this was necessary in CI, but it's not clear to me what the right mechanism is to enforce that. However, changes to the adapter should be infrequent, so hopefully this isn't too much of a burden.