-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stellate viceroy changes to enable rich integration tests #354
Open
dpetrick
wants to merge
20
commits into
fastly:main
Choose a base branch
from
StellateHQ:local_integration_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state in between invocations.
Implement purging.
dpetrick
changed the title
Local integration tests
Stellate viceroy changes to enable rich integration tests
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: We do not expect this to get merged, instead, we want to showcase what we need to make Viceroy work for local integration testing and local developer experience.
At Stellate, we're in need of an integration test harness and more flexible local developer experience compared to what is currently possible with the Viceroy lib. This PR shows what parts of Viceroy we expanded with new capabilities in order for it to be powerful enough to build a testing framework around it.
Endpoint
(log sink) messages programmatically by having them write to an in-memory buffer that can be read from outside of the execution context after an invocation. Technically this could have been intercepted from stdout before, but this is much more convenient.Backend
s to whichRequest
s will be passed.Ideally, these changes (or at least comparable changes) make it into Viceroy so we don't have to maintain a fork. We're happy to have a discussion what needs to be done, talk through ideas, walk through code and give you access to our testing code so you can directly see and play around with how we envision Viceroy to function in an integration test setup.
Note that we'll record a video on the ins and outs / requirements and we'll also reach out to you directly via Slack with a document to start a discussion.
Implementation notes