Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubbed-out values for remaining FASTLY_ environment variables. #337

Merged
merged 1 commit into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/src/linking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,17 @@ pub(crate) fn create_store(
fn make_wasi_ctx(ctx: &ExecuteCtx, session: &Session) -> Result<WasiCtx, anyhow::Error> {
let mut wasi_ctx = WasiCtxBuilder::new();

// Viceroy provides a subset of the `FASTLY_*` environment variables that the production
// Viceroy provides the same `FASTLY_*` environment variables that the production
elliottt marked this conversation as resolved.
Show resolved Hide resolved
// Compute platform provides:

wasi_ctx
// These variables are stubbed out for compatibility
.env("FASTLY_CACHE_GENERATION", "0")?
.env("FASTLY_CUSTOMER_ID", "0000000000000000000000")?
.env("FASTLY_POP", "XXX")?
.env("FASTLY_REGION", "Somewhere")?
.env("FASTLY_SERVICE_ID", "0000000000000000000000")?
.env("FASTLY_SERVICE_VERSION", "0")?
// signal that we're in a local testing environment
.env("FASTLY_HOSTNAME", "localhost")?
// request IDs start at 0 and increment, rather than being UUIDs, for ease of testing
Expand Down
26 changes: 24 additions & 2 deletions test-fixtures/src/bin/env-vars.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,34 @@
use std::env;

fn main() {
let host_name = env::var("FASTLY_HOSTNAME").expect("host name available");
assert_eq!(host_name, "localhost");
let id: u64 = env::var("FASTLY_CACHE_GENERATION")
.expect("cache generation available")
.parse()
.expect("parses as u64");

let sid = env::var("FASTLY_CUSTOMER_ID").expect("customer ID available");
assert_eq!(sid, "0000000000000000000000");

let sid = env::var("FASTLY_POP").expect("POP available");
assert_eq!(sid, "XXX");

let sid = env::var("FASTLY_REGION").expect("region available");
assert_eq!(sid, "Somewhere");

let sid = env::var("FASTLY_SERVICE_ID").expect("service ID available");
assert_eq!(sid, "0000000000000000000000");

let id: u64 = env::var("FASTLY_SERVICE_VERSION")
.expect("service version available")
.parse()
.expect("parses as u64");

let id: u64 = env::var("FASTLY_TRACE_ID")
.expect("trace ID available")
.parse()
.expect("parses as u64");
assert_eq!(id, 0);

let host_name = env::var("FASTLY_HOSTNAME").expect("host name available");
assert_eq!(host_name, "localhost");
}