Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Add options to customize behavior of unknown Wasm imports #313

Merged
merged 1 commit into from
Sep 22, 2023

Commits on Sep 19, 2023

  1. 👻 Add options to customize behavior of unknown Wasm imports

    Adds a new shared option to the CLI with three behavior modes:
    
    ```
          --unknown-import-behavior <UNKNOWN_IMPORT_BEHAVIOR>
              Set the behavior for unknown imports.
    
              Note that if a program only works with a non-default setting for this flag, it is unlikely to be publishable to Fastly.
    
              [default: link-error]
    
              Possible values:
              - link-error:   Unknown imports are rejected at link time (default behavior)
              - trap:         Unknown imports trap when called
              - zero-or-null: Unknown imports return zero or a null pointer, depending on the type
    ```
    
    This ended up touching more files than I'd expect, because I had to make the integration test
    harness bubble out link-time errors rather than `.expect()`ing them, so there are quite a few new
    `?`s across the integration test suite.
    acfoltzer committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f048fd9 View commit details
    Browse the repository at this point in the history