Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the new config store hostcalls. #296

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Support the new config store hostcalls. #296

merged 1 commit into from
Aug 3, 2023

Conversation

acw
Copy link
Contributor

@acw acw commented Aug 3, 2023

These work by naively just forwarding the new hostcalls into the underlying dictionary system; these pass the tests, but I'd love someone to confirm (preferably someone named @acfoltzer) that this is intended behavior.

@acw acw requested a review from acfoltzer August 3, 2023 18:19
ulyssa
ulyssa approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ulyssa ulyssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! And I believe that forwarding is the appropriate behaviour for Viceroy. I believe the hostcall's intended difference in xqd is that it doesn't go through the sidecar, which doesn't matter here.

@acw acw merged commit 4ab8954 into main Aug 3, 2023
7 checks passed
@acw acw deleted the awick/new-store-hostcalls branch August 3, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulyssa ulyssa ulyssa approved these changes

@acfoltzer acfoltzer Awaiting requested review from acfoltzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acw @ulyssa