Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime.txt for Netlify preview #1211

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

joshdholtz
Copy link
Member

No description provided.

@joshdholtz joshdholtz merged commit f15938c into master Sep 18, 2023
4 checks passed
@joshdholtz joshdholtz deleted the joshdholtz-fix-netlify-preview branch September 18, 2023 09:47
@janbrasna
Copy link
Contributor

@rogerluan Yo, doesn't this by any chance align with moving the preview build distro from Xenial (legacy) to Focal (LTS) at Netlify? If so, the runtime.txt could be removed altogether (as 3.8 is /should be/ the default for Focal builds), see:

The reason is the runtime.txt formatted this way for Netlify is not the correct syntax per se, see #1164 for elaboration.

Maybe now the LTS distro env would pick up all the other Python version definitions that were tried to no avail before on the old OS with no effect as demonstrated in #1121 etc.? Probably the current Pipfile [requires] python_version = "3" should alone be enough to make sure it builds on the new runner. (Why it was bugged on the old… who knows. But there were reports left to right running into the same bugs…)

@rogerluan
Copy link
Member

@janbrasna thanks for the suggestion, should this migration literally be just deleting the file, or does it require changing something in netlify?

Do you mind opening a PR for this so we can test? 😊

@janbrasna
Copy link
Contributor

@rogerluan My guess is yes, will dig around the logs to closely inspect what env is being picked up, TBD #1236

(In the past, legacy image was used in Netlify admin UI and the hacks mentioned above were needed for the mkdocs to build. That distro has been deprecated and possibly completely removed and the project either manually or forcibly moved to the TLS Ubuntu images, where the hack is not needed anymore.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants