Add the ability to upload any files to s3 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshdholtz following our talk yesterday. |
|
Wow, this PR is what I need. (Hidden +1. Need to upload mapping.txt too, not just the apk) |
jaximan
pushed a commit
to jaximan/fastlane-plugin-s3
that referenced
this pull request
Jun 26, 2019
* Allow to upload any file * File upload : fix issue with file name * Allow to upload a whole folder * Fixed some things with paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the ability to upload just any file to S3, along with an IPA/APK or not.
Motivation
Uploading stuff to S3 is more and more common. Typically upload test screenshots after a snapshot run is a common usecase.
To avoid making another plugin (and another action i could not name!) and handling all the s3 auth complexity again: add the ability to pass files to upload to s3 along with the ipa file (or not)
May solve #32