Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: kubernetes-model-admissionregistration generated from OpenAPI schemas #6174

Merged
merged 3 commits into from
Jul 23, 2024
Merged

refactor: kubernetes-model-admissionregistration generated from OpenAPI schemas #6174

merged 3 commits into from
Jul 23, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 23, 2024

Description

Fixes #6166

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 7.0.0 milestone Jul 23, 2024 — with automated-tasks
@manusa manusa force-pushed the refactor/openapi-kubernetes-model-admissionregistration branch from d39d829 to efc0f10 Compare July 23, 2024 07:51
@manusa manusa force-pushed the refactor/openapi-kubernetes-model-admissionregistration branch 2 times, most recently from 0f19068 to 0564ce6 Compare July 23, 2024 10:30
@manusa manusa force-pushed the refactor/openapi-kubernetes-model-admissionregistration branch from 0564ce6 to 4bf619c Compare July 23, 2024 10:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa manusa merged commit 1545ba2 into fabric8io:main Jul 23, 2024
21 checks passed
@manusa manusa deleted the refactor/openapi-kubernetes-model-admissionregistration branch July 23, 2024 13:20
@rohanKanojia rohanKanojia mentioned this pull request Jul 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Replace Go model generation for kubernetes-model-admissionregistration
2 participants
@manusa @rohanKanojia