Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of Analyzer for Bird Watcher #134

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pertrai1
Copy link
Contributor

@pertrai1 pertrai1 commented Jan 2, 2022

Based on the below from design doc - https://github.com/exercism/javascript/blob/main/exercises/concept/bird-watcher/.meta/design.md


  • For all tasks check that the student actually used a for loop.

totalBirdCount

  • Verify that the condition is written with < x.length instead of <= y.length -1.
  • Check whether a shorthand assignment += was used to increase the sum (non-essential feedback).
  • Verify the total was properly initialized with 0 instead of e.g. null
  • Verify the increment operator was used in loop header step

birdsInWeek

  • Verify a helper variable was used instead of duplicating the calculation in the initialization and condition of the loop
  • Other checks should be the same as for totalBirdCount

fixBirdCountLog

  • Check that no if-statement was used (it is not necessary if the step size was set correctly), type actionable
  • Check whether a shorthand assignment += was used to increase the loop counter (non-essential feedback)
  • Check whether the increment operator was used in the loop body

  • modify index.ts for output
  • create custom comments where needed

@pertrai1 pertrai1 marked this pull request as draft January 2, 2022 04:10
@junedev
Copy link
Member

junedev commented Jan 4, 2022

@pertrai1 FYI I added one item to the list for the last task that I saw a lot recently in mentoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants