Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configlet action #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

wolf99
Copy link

@wolf99 wolf99 commented Oct 28, 2021

Per #29

In draft until there is a decision on that issue about how to propagate the change to tracks.

@SaschaMann
Copy link
Contributor

SaschaMann commented Oct 29, 2021

We should probably leave this here but deprecated for a fairly long time, at least a month or so. Otherwise PRs on tracks will fail unless they're all rebased.

We could add a warning to the action too, though I'm not sure people read them.

@SaschaMann
Copy link
Contributor

My preference for this PR would be that we add the note to both READMEs but leave the action so that it doesn't break non-rebased PRs. Then we can delete the rest of it a few months from now (or never, idc)

@wolf99
Copy link
Author

wolf99 commented Dec 11, 2021

Ready for review, but ideally requires exercism/configlet#462 to be merged before this is merged.

@wolf99 wolf99 marked this pull request as ready for review December 11, 2021 17:31
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but prefer waiting for the other PR to get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants