this is to fix github actions error #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the LEAVE function is being used for stopping the script gracefully but it is also being used in the end for exiting after script have ran successfully, this might not break the build in local host but causing an error in Github actions as the script exits with exit 1, which is considered as failure even when the output gsi image is created successfully, this https://github.com/nit-in/erfan_gsi_mmx_6746/actions/runs/1206555548 run might give an idea as the gsi is created but workflow fails Solution: using other function BYE or exit 0 at the end Signed-off-by: nit-in <[email protected]>
as the script runs successfully, unmount the partitions and clean the working directory before exiting same as LEAVE function Signed-off-by: nit-in <[email protected]>
|
Why is this necessary? Since you can fork it instead of pushing dummy code to official repo. In my opinion, no need to do it. You can try to use |
|
make it dependent on CLEAN argument |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the LEAVE function is being used for stopping the script gracefully
but it is also being used in the end for exiting after script have ran successfully,
this might not break the build in local host but causing an error in Github actions
as the script exits with exit 1, which is considered as failure (in bash) even when the output gsi image is created successfully,
this https://github.com/nit-in/erfan_gsi_mmx_6746/actions/runs/1206555548 run might give an idea
as the gsi is created but workflow fails
Solution: using other function BYE or exit 0 at the end
Signed-off-by: nit-in [email protected]