-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fedora Support and CentOS Support #132
base: master
Are you sure you want to change the base?
Conversation
can u add a check to auto detect fedora, without user interaction |
I tried auto-detecting, but I ran and get somewhat wrong. So I changed to manual check. |
For RHEL, os-release may be a single line ...? e.g.
|
It works. Thanks for your unique method. |
we already have a distro check https://github.com/erfanoabdi/ErfanGSIs/pull/132/files#diff-6aa367da3fdfc952b15def7759aa5f0bL4 |
I tried and this method cannot work. See 5e1532b |
Maybe https://github.com/erfanoabdi/ErfanGSIs/pull/132/files#diff-6aa367da3fdfc952b15def7759aa5f0bL4 works on 'arch' or some other distros, but not on 'fedora'. |
Also,One caveat is that Fedora is not GNU. |
I am so shocked that the setup process on Arch Linux is much easier than which on CentOS a2eae23 . |
any further additions to this? |
See issue #131