Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cxf 102607 #55

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Cxf 102607 #55

merged 6 commits into from
Oct 11, 2024

Conversation

tutkat
Copy link
Contributor

@tutkat tutkat commented Oct 3, 2024

https://equinixjira.atlassian.net/browse/CXF-102607

fix: GHA Test Runs for Java SDK

@tutkat tutkat requested a review from thogarty October 3, 2024 06:28
@thogarty
Copy link
Contributor

thogarty commented Oct 8, 2024

@tutkat , the change looks good, but the test runner is still failing for this branch: https://github.com/equinix-labs/fabric-java/actions/runs/11214533620

Please retitle PR to fix: GHA Test Runs for Java SDK and add in the successful test run to this PR when your changes satisfy it. Thank you!

@thogarty
Copy link
Contributor

Note from @tutkat ,

"it should be fixed automatically if we generate new sdk version based on new swagger, so for the next release branch it should be fixed (missing enums will be added to repo from openapi generator side)"

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@tutkat tutkat merged commit 428c520 into main Oct 11, 2024
1 check passed
@tutkat tutkat deleted the CXF-102607 branch October 11, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants