Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects page #985

Merged
merged 29 commits into from
Dec 21, 2023
Merged

Projects page #985

merged 29 commits into from
Dec 21, 2023

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Nov 29, 2023

This PR uses users db from #970, so must be merged after Users reviewed.

image image image

Tweaked a bit of design.

We also have few issues like: epicmaxco/vuestic-ui#4047 or epicmaxco/vuestic-ui#4046 (fixed in Admin)

I still don't know what message a plus buttons should do in cards.

m0ksem and others added 20 commits November 3, 2023 03:06
@m0ksem
fix: show vuestic-ui types
78acd79
@m0ksem
raw: init users page
a60bb3d
@m0ksem
chore: update vuestic-ui and remove hotfixes
b0246f8
@m0ksem
fix: satiesfies eslint error
e41bece
@m0ksem
fix: statiesfies prettier warning
9ece03e
@m0ksem
chore: apply prettier fixes
21f957f
@m0ksem
feat(users): finish users page
ea02e30
@m0ksem
chore: small refactoring
0c2215c
@m0ksem
chore: fix vue warning
4252010
@asvae
Merge branch 'develop' into fix#968/users-page
7f88a9c
@m0ksem
chore(users): remove extra stores and components
a30b78a
@m0ksem
feat(users): add confirmation window and toasts.
92e61f9
@m0ksem
fix(users): add active checkbox to edit form
5fa8386
@m0ksem
fix(users): blob avatar rendering
f92b1b2
@m0ksem
chore: remove todo
e794493
@m0ksem
Merge branch 'develop' into fix#968/users-page
1d48b8e
@m0ksem
chore: eslint fixes
2a93bac
@m0ksem
chore: improve users page
18e92a0
@m0ksem
init projects page
02cf7b5
@m0ksem
feat(projects): finish projects page
c58f1ae
@m0ksem m0ksem requested a review from asvae November 29, 2023 05:47
@asvae asvae changed the title fix: show vuestic-ui types Projects page Nov 30, 2023
@m0ksem m0ksem mentioned this pull request Dec 1, 2023
Closed
4 tasks
@asvae asvae assigned asvae, m0ksem and Fsss126 and unassigned Fsss126 Dec 4, 2023
asvae
asvae requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We're close, but still needs some polish.

src/pages/users/UsersPage.vue
@@ -0,0 +1,106 @@
<script setup lang="ts">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a bunch of console errors:

image

src/pages/users/UsersPage.vue Show resolved Hide resolved
src/pages/users/UsersPage.vue Show resolved Hide resolved
src/pages/projects/ProjectsPage.vue Show resolved Hide resolved
src/pages/projects/ProjectsPage.vue Show resolved Hide resolved
src/pages/projects/ProjectsPage.vue Show resolved Hide resolved
src/pages/users/UsersPage.vue Show resolved Hide resolved
src/pages/users/UsersPage.vue Show resolved Hide resolved
src/pages/users/UsersPage.vue Show resolved Hide resolved
src/pages/users/UsersPage.vue Show resolved Hide resolved
@m0ksem m0ksem mentioned this pull request Dec 4, 2023
Closed
@asvae
Copy link
Member

asvae commented Dec 21, 2023 •
edited
Loading

  • When I select inactive filter, then search for users - I see active users
    image
  • Buttons are too big compared to design
    image
  • When I remove or edit a user - list gets smaller (tells "results on the page 10" even though there is 5). It should stay the same size and get users from next page.
    image
  • Maybe this entry uses the same id or something?
    image
  • Do we really need a capital letter before every name?
    image
  • When we reload project page with table - we get card layout. It should keep layout in local storage.
  • When I add project - I get infinite loading
    image

@asvae asvae mentioned this pull request Dec 21, 2023
Open
@asvae asvae merged commit 7ae4f3c into epicmaxco:develop Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvae asvae asvae requested changes

Assignees

@asvae asvae

@m0ksem m0ksem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m0ksem @asvae @Fsss126